-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump fast-xml-parser from 4.4.0 to 4.4.1 in /TVOSExample #2272
Merged
kkafar
merged 5 commits into
@kkafar/dependabot-aggregate
from
dependabot/npm_and_yarn/TVOSExample/fast-xml-parser-4.4.1
Jul 31, 2024
Merged
chore(deps): bump fast-xml-parser from 4.4.0 to 4.4.1 in /TVOSExample #2272
kkafar
merged 5 commits into
@kkafar/dependabot-aggregate
from
dependabot/npm_and_yarn/TVOSExample/fast-xml-parser-4.4.1
Jul 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description This PR adds missing icon and launch screen to `FabricExample` app. After copying the icons from paper example i noticed there are icons for iPad and the example itself supports iPad platform. Thus I decided to add the iPad support to fabric example as well. ## Changes - added iOS icons and launch screen - added iPad support - added android icons and launch screen ## Screenshots / GIFs ### Before ![Screenshot 2024-07-30 at 11 13 17](https://github.com/user-attachments/assets/791dd46d-7e4a-4e54-bcfa-20893255dfe3) ![Screenshot 2024-07-30 at 11 15 08](https://github.com/user-attachments/assets/98c9d114-270c-4ccf-b876-b7215ee70a43) ### After ![Screenshot 2024-07-30 at 13 20 29](https://github.com/user-attachments/assets/c1c29c73-fd5b-4f33-820d-424fea6fdf15) ![Screenshot 2024-07-30 at 12 54 53](https://github.com/user-attachments/assets/1d033532-4d5b-465d-9289-19da50674013) ## Checklist - [x] Ensured that CI passes
…nd native-stack navigators (#2260) ## Description Currently, while switching between BottomTabNavigator and NativeStackNavigator, user cannot interact with screens from BottomTabNavigator. That's because while we're coming back to the previous screen, original screen frame has frame (0, 0, 0, 0). I've investigated that even if we're calling updateLayoutMetrics on a view, it's not being updated, since the RNSScreen implementation of that method firstly checks if `parentVC` is not RNSNavigationContainer and if it's not nil -> Because it's always nil during the insertion (as we're calling for screen updates too late), we're never updating layout metrics. Fixes #2252. ## Changes - Moved calling for parent updates before updating layout metrics. ## Screenshots / GIFs ### Before https://github.com/user-attachments/assets/8da01059-e488-43e4-ab44-2286b7cd3078 ### After https://github.com/user-attachments/assets/b7336425-bb01-4c66-80e7-4e8d83ca995d ## Test code and steps to reproduce You can test `Test2252.tsx` to check these changes. ## Checklist - [X] Included code example that can be used to test this change - [x] Ensured that CI passes
PR fixing animations on Fabric. The problem started in RN 0.74, from which suspending the component triggers its useLayoutEffect. It has the consequences in Animated since detaching the native node happens then: facebook/react-native@a5b84b9/packages/react-native/Libraries/Animated/useAnimatedProps.js#L221-L238.
## Description <!-- Description and motivation for this PR. Include Fixes #<number> if this is fixing some issue. Fixes # . --> PR adding support for RN 0.75 in the library --------- Co-authored-by: Kacper Kafara <kacperkafara@gmail.com>
Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) from 4.4.0 to 4.4.1. - [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases) - [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md) - [Commits](NaturalIntelligence/fast-xml-parser@v4.4.0...v4.4.1) --- updated-dependencies: - dependency-name: fast-xml-parser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
Dependencies
Pull requests that update a dependency file
javascript
Pull requests that update Javascript code
labels
Jul 31, 2024
kkafar
deleted the
dependabot/npm_and_yarn/TVOSExample/fast-xml-parser-4.4.1
branch
July 31, 2024 09:06
8 tasks
kkafar
added a commit
that referenced
this pull request
Aug 5, 2024
## Description * #2266 * #2272 ## Changes <!-- Please describe things you've changed here, make a **high level** overview, if change is simple you can omit this section. For example: - Updated `about.md` docs --> <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Updated documentation: <!-- For adding new props to native-stack --> - [ ] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [ ] Ensured that CI passes --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Janic Duplessis <janicduplessis@gmail.com> Co-authored-by: Alex Duży <91994767+alduzy@users.noreply.github.com> Co-authored-by: Tymoteusz Boba <Tymoteusz.Boba@gmail.com> Co-authored-by: Wojciech Lewicki <wojciech.lewicki@swmansion.com>
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
## Description * software-mansion#2266 * software-mansion#2272 ## Changes <!-- Please describe things you've changed here, make a **high level** overview, if change is simple you can omit this section. For example: - Updated `about.md` docs --> <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Updated documentation: <!-- For adding new props to native-stack --> - [ ] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [ ] Ensured that CI passes --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Janic Duplessis <janicduplessis@gmail.com> Co-authored-by: Alex Duży <91994767+alduzy@users.noreply.github.com> Co-authored-by: Tymoteusz Boba <Tymoteusz.Boba@gmail.com> Co-authored-by: Wojciech Lewicki <wojciech.lewicki@swmansion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Dependencies
Pull requests that update a dependency file
javascript
Pull requests that update Javascript code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps fast-xml-parser from 4.4.0 to 4.4.1.
Changelog
Sourced from fast-xml-parser's changelog.
... (truncated)
Commits
d40e29c
update package detail and browser bundlesd0bfe8a
fix maxlength for currency value2c14fcf
Update bug-report-or-unexpected-output.mdacf610f
fix #634: build attributes with oneListGroup and attributesGroupName (#653)931e910
fix: get oneListGroup to work as expected for array of strings (#662)b8e40c8
Update ISSUE_TEMPLATE.mda6265ba
chore: add trend image (#658)db1c548
redesign README.md338a2c6
Rename 1.Getting Started.md to 1.GettingStarted.mdc762537
Rename v5 docs filenames (#659)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.